Add metadata-specific aria labels to more/less buttons (fixes UV issue 1081) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Oct 21, 2024
demiankatz
reviewed
Oct 22, 2024
There was a problem hiding this comment.
The logic here makes sense to me -- but the question is, does this change break the demo within this repository because @edsilv/jquery-plugins needs to be updated with the new behavior? Do we need to figure out a way to solve that before we merge this, or do we want to get this pushed through first and then double back to address that problem?
Should we perhaps consider just moving that whole function into this project instead of making it an external dependency? It would make everything less fragile and easier to manage, and I don't see a long-term future for shared jQuery plugins anyway.
Closed
1 task
demiankatz
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in tandem with a PR to UV: UniversalViewer/universalviewer#1156
It fixes UV issue 1081
This will allow iiif-metadata-component to display full aria labels specific to each piece of metadata.