Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): show columns #351

Merged

Conversation

RemHero
Copy link
Collaborator

@RemHero RemHero commented Jun 4, 2024

PR 描述

这是对show columns的优化改造,主要包括以下几个方面的更新:

  • 功能增强:增强了对接层接口的表达能力,getColumns函数语义更清晰。
  • 性能提升:将show columns后的正则下推到对接层实现,减少读取的列的数量和内存占用。
  • 错误修复
    1. 修复了原有show columns中无法仅显示满足dataPrefix的列,而显示全部dummy列。
    2. 对接层修复了对列isDummy属性的判断。
    3. 修复了show columns无法查询前缀带有schemaPrefix的列的bug。

各对接层show columns详细实现

对接层 非dummy dummy
Mongodb 后过滤(Mongodb无法有选择地列出集合名称) 直接查询
Redis 查询+后过滤(后过滤用于过滤tagkv) 直接查询
Parquet 后过滤(列名直接保存在内存中,但是没有建立索引) 后过滤(列名需要从Parquet文件中读取,无法有选择地读取)
FileSystem list file实现 直接查询
IoTDB12 直接查询 直接查询
InfluxDB 查询+后过滤(后过滤用于过滤tagkv) 直接查询
  • 直接查询:通过查询直接获取所需的列,不需要再次过滤,不会读取多余的列
  • 后过滤:先获取所有列,然后在对接层代码中过滤

@RemHero RemHero changed the title Feat show columns prefix filter push down test feat(core): show columns Jun 6, 2024
@RemHero RemHero closed this Jun 6, 2024
@RemHero RemHero reopened this Jun 6, 2024
@RemHero RemHero closed this Jun 7, 2024
@RemHero RemHero reopened this Jun 7, 2024
@RemHero RemHero closed this Jun 8, 2024
@RemHero RemHero reopened this Jun 8, 2024
@jzl18thu jzl18thu closed this Jul 28, 2024
@jzl18thu jzl18thu reopened this Jul 28, 2024
@jzl18thu jzl18thu closed this Jul 28, 2024
@jzl18thu jzl18thu reopened this Jul 28, 2024
@jzl18thu jzl18thu closed this Aug 5, 2024
@jzl18thu jzl18thu reopened this Aug 5, 2024
This reverts commit 7832a82.
@jzl18thu jzl18thu closed this Aug 5, 2024
@jzl18thu jzl18thu reopened this Aug 5, 2024
@jzl18thu jzl18thu closed this Aug 6, 2024
@jzl18thu jzl18thu reopened this Aug 6, 2024
@jzl18thu jzl18thu closed this Aug 6, 2024
@jzl18thu jzl18thu reopened this Aug 6, 2024
@zhuyuqing zhuyuqing merged commit 3c4919d into IGinX-THU:main Aug 8, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants