Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subprocess): wait for process stop in case of None returncode #80

Merged
merged 4 commits into from
Mar 28, 2024
Merged

fix(subprocess): wait for process stop in case of None returncode #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
884235e
Merge pull request #75 from IGNF/develop
azarz Mar 12, 2024
e580b63
Merge pull request #78 from IGNF/develop
azarz Mar 22, 2024
8d4935f
fix(subprocess): wait for process stop in case of None returncode
jmkerloch Mar 28, 2024
256c72e
Merge pull request #79 from IGNF/fix/subprocess_returncode
azarz Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## x.y.z

## 2.2.6

FIXED:
- subprocess : None value can be returned as returncode. Need to wait for process stop in this case

## 2.2.5

CHANGED:
Expand Down
7 changes: 5 additions & 2 deletions r2gg/_subprocess_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,12 @@ def subprocess_execution(args, logger, outfile = None):
process_output, _ = process.communicate()
logger.info(process_output.decode("utf-8"))

returncode = process.returncode
# Wait for process stop
while process.returncode is None:
process.wait()

if process.returncode != 0:
error_msg = f"Invalid returncode {returncode} for subprocess '{subprocess_arg}'"
error_msg = f"Invalid returncode {process.returncode} for subprocess '{subprocess_arg}'"
logger.error(error_msg)
raise RuntimeError(error_msg)

Expand Down
Loading