limited OSRM native routing API #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters, and ignored when not. OSRM controller's writeRouteResponse is being implemnted, but it will need modifications of RouteResponse class.
…. Slight edition of routeResponse and osrmSource classes to do so.
TODO : * complete logging and varible check * test the code
* check result to see if every property is valid and exact. * adapt getcapabilities to OSRM API capabilities.
|
The current state (d9d931b) has only been testing on a singular routing request, with intermediates coordinates / waypoints. |
lgrd
reviewed
Jan 24, 2024
lgrd
reviewed
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited OSRM native routing API for road2
Linked to issue #87.
This PR covers only routing request and responses with OSRM formalism, and using an OSRM source engine.
OSRM query parameters, mandatory or not, are used if they already had an equivalent in road2's code.
Other optional parameters are ignored.
Aside from these ignored paramters, the request and response are compatible with OSRM specifications.
routeRequesthas been updated with a property namedengineExtras, a dictionary designed to contain engine response properties used by an API other than "simple". As an example, OSRM waypoint's distance to requested coordinates is such a property.osrmSourcehas been updated to setrouteRequest.engineExtraswith this kind of additional properties, necesssary to craft OSRM native API response.