feat(valhalla): allow to configure exec timeout #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
|
Added the changelog part. |
azarz
approved these changes
Dec 18, 2024
azarz
added a commit
that referenced
this pull request
Dec 18, 2024
* Merge doc/translate in develop (#107) * Test commit * test commit * test commit IDE * First draft on english documentation * Drafting the english doc * second draft of doc * Adding modifications from fr develop doc * corrections de coquilles sur les liens * corrections de coquilles sur les liens * update coquilles liens * test commit * test commit IDE * First draft on english documentation * second draft of doc * Adding modifications from fr develop doc * update coquilles liens * draft: main readme in english * fix: main readme test * fix typo test * fix : finish rebase * fix typo and switch to default french * fix readme for introduction --------- Co-authored-by: JRS <[email protected]> * feat: handle exec maxBuffer size with environment variable * feat: update changelog * Changelog.md * Bump version in package.json * feat(valhalla): allow to configure exec timeout (#111) * feat(valhalla): allow to configure exec timeout * doc: add exec_tiemout description * doc: update changelog * Bump package.json --------- Co-authored-by: lgrd <[email protected]> Co-authored-by: JRS <[email protected]> Co-authored-by: Matthieu Proboeuf <[email protected]> Co-authored-by: Aurelien <[email protected]>
|
@tetram l'image docker embarquant le changement est publiée ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure a timeout on valhalla_service
execWhen requesting a valhalla source, if the http request is canceled (client termination or reverse proxy timeout) the
valhalla_serviceprocess continues to run.The idea is to allow to set a timeout (close to the reverse proxy one) so the process won't continue to run when the underlying http request is already terminated.