Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add search radius plugin #1

Merged
merged 52 commits into from
May 30, 2024
Merged

add search radius plugin #1

merged 52 commits into from
May 30, 2024

Conversation

alavenant
Copy link
Collaborator

No description provided.

@alavenant
add search radius plugin
608d380 
fix environment

test ci

fix compil windows

radius_search : remove dimRange and use special attributes

fix cmakelist
leavauchier
leavauchier reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@leavauchier leavauchier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a encore pas mal de chose que j'ai pas regarddée mais j'enregistre une première salve de commentaires

environment.yml Show resolved Hide resolved
macro/ex_filtering_points.py Outdated Show resolved Hide resolved
macro/ex_filtering_points.py Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
test/test_radius_search.py Outdated Show resolved Hide resolved
test/test_radius_search.py Outdated Show resolved Hide resolved
test/test_radius_search.py Outdated Show resolved Hide resolved
test/test_radius_search.py Outdated Show resolved Hide resolved
@leavauchier
Copy link
Contributor

On pourrait envisager du formattage avec clang pour le c++ + black pour le python histoire d'avoir quelque chose de propre assez tôt

leavauchier
leavauchier reviewed May 15, 2024
View reviewed changes
doc/grid_radius_search.md Outdated Show resolved Hide resolved
doc/grid_radius_search.md Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
leavauchier
leavauchier requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@leavauchier leavauchier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pense avoir fini une première revue, désolée pour le spam

src/filter_grid_decimation/grid_decimationFilter.cpp Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
test/test_radius_search.py Outdated Show resolved Hide resolved
test/test_grid_decimation.py Outdated Show resolved Hide resolved
@alavenant
Copy link
Collaborator Author

On pourrait envisager du formattage avec clang pour le c++ + black pour le python histoire d'avoir quelque chose de propre assez tôt

ajout de pre-comit et du fichier de config

leavauchier
leavauchier reviewed May 27, 2024
View reviewed changes
macro/macro.py Outdated Show resolved Hide resolved
test/test_radius_assign.py Outdated Show resolved Hide resolved
test/test_radius_search.py Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
src/filter_radius_search/radius_searchFilter.cpp Outdated Show resolved Hide resolved
macro/macro.py Outdated Show resolved Hide resolved
leavauchier
leavauchier reviewed May 29, 2024
View reviewed changes
doc/radius_assign.md Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
macro/ex_filtering_points.py Show resolved Hide resolved
macro/ex_filtering_points2.py Outdated Show resolved Hide resolved
macro/ex_filtering_points2.py Outdated Show resolved Hide resolved
src/filter_grid_decimation/GridDecimationFilter.cpp Outdated Show resolved Hide resolved
test/test_grid_decimation.py Show resolved Hide resolved
macro/ex_filtering_points2.py Outdated Show resolved Hide resolved
@leavauchier leavauchier merged commit 139a137 into main May 30, 2024
1 check passed
@leavauchier leavauchier deleted the add_radius_search branch May 30, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leavauchier leavauchier leavauchier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alavenant @leavauchier