Change ppp iframe link,display error message in surge pages #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utsukta1
requested review from
samshara,
puranban,
shreeyash07,
barshathakuri,
UjjwalDhakal7,
fereeca and
roshni73
shreeyash07
approved these changes
Jan 12, 2024
shreeyash07
requested changes
Jan 16, 2024
| urlParams: { countryId: item.country_from?.id }, | ||
| }), | ||
| (item) => { | ||
| if (item.country_from?.id) { |
There was a problem hiding this comment.
use isDefined or isNotDefined from fujs
samshara
reviewed
Jan 16, 2024
Comment on lines
+136
to
+140
| if (isDefined(item.country_from?.record_type === 3)) { | ||
| return { | ||
| to: undefined, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Let's add a NOTE here.
// NOTE: we don't have the correct mapping for region
| @@ -8,6 +8,7 @@ | |||
| "personnelTableType": "Type", | |||
| "personnelTableDeployedTo": "Deploying To", | |||
| "personnelTableDeployedParty": "Deploying Party", | |||
| "deployedPersonnelViewAll": "View All Deployed Personnel" | |||
| "deployedPersonnelViewAll": "View All Deployed Personnel", | |||
| "emergencySurgePartyNotFound": "sorry, this party has no one matching country to be shown" | |||
Comment on lines
+143
to
+147
| (item) => { | ||
| if (isDefined(item.country_from?.record_type === 3)) { | ||
| return { | ||
| to: undefined, | ||
| }; |
There was a problem hiding this comment.
Let's use a constant to denote region type.
For example
export const TYPE_IMMINENT = 0 satisfies TypeOfDrefEnum;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.logmeant for debugging