Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn workspace for go web app #417

Closed
wants to merge 0 commits into from

Conversation

samshara
Copy link
Member

@samshara samshara commented Dec 29, 2023

Changes

  • Migrate to mono repo architecture for go-web-app
  • Move client application code under app
  • Move UI components to a new folder under packages/ui
  • Package UI components as a separate library under @ifrc-go/ui
  • Use UI components from the @ifrc-go/ui
  • Reorder the imports in the go-web-app
  • Modify Github CI to build the app

Note

  • We need to ensure the Production CI can build the app (@frozenhelium )

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@szabozoltan69
Copy link
Collaborator

Could you please give me a short brief about the advantage of this monorepo feature?

@samshara
Copy link
Member Author

samshara commented Jan 2, 2024

Could you please give me a short brief about the advantage of this monorepo feature?

@szabozoltan69 we will write a detail on it later. This could also be a discussion on the dev call.

@samshara samshara force-pushed the project/country-pages branch from 13c6fd3 to 25563bf Compare January 12, 2024 08:29
@samshara samshara force-pushed the feature/monorepo branch 2 times, most recently from 8208089 to 5f51aee Compare January 17, 2024 08:40
@samshara samshara force-pushed the project/country-pages branch from dbdd9f3 to cdd16cf Compare January 23, 2024 08:47
@samshara samshara force-pushed the project/country-pages branch from 633d145 to 95dbb80 Compare January 24, 2024 06:00
@samshara samshara marked this pull request as ready for review January 24, 2024 11:12
@samshara samshara closed this Jan 24, 2024
@samshara samshara deleted the feature/monorepo branch January 24, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants