Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project/alpha nginx serve #1447

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Project/alpha nginx serve #1447

merged 4 commits into from
Nov 7, 2024

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Oct 31, 2024 •
edited
Loading

Addresses:

  • Helm Chart for Alpha instances

Changes

  • Publish nginx-serve static build and helm chart
  • Add few config mutations for nginx-serve static build
  • Add helm chart for nginx-serve

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2f58e53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thenav56 thenav56 force-pushed the project/alpha-nginx-serve branch from 05f6662 to d0d131a Compare November 5, 2024 07:59
@thenav56 thenav56 requested review from tnagorra and samshara November 5, 2024 12:52
@tnagorra tnagorra force-pushed the project/alpha-nginx-serve branch from a980b3a to 1cbf11d Compare November 6, 2024 05:28
@thenav56 thenav56 marked this pull request as ready for review November 6, 2024 05:36
@thenav56 thenav56 force-pushed the project/alpha-nginx-serve branch from df7208b to 1d7e50f Compare November 6, 2024 17:34
@thenav56
Fix overwrite error
98b3641 
Using `|` as delimiter for all sed commands
Using \< \> as word break for all sed commands
@thenav56 thenav56 force-pushed the project/alpha-nginx-serve branch from 1d7e50f to 98b3641 Compare November 6, 2024 17:52
tnagorra
tnagorra reviewed Nov 7, 2024
View reviewed changes
nginx-serve/Dockerfile Outdated Show resolved Hide resolved
nginx-serve/Dockerfile Outdated Show resolved Hide resolved
nginx-serve/Dockerfile Outdated Show resolved Hide resolved
app/env.ts Show resolved Hide resolved
nginx-serve/Dockerfile Show resolved Hide resolved
@thenav56 thenav56 mentioned this pull request Nov 7, 2024
Merged
6 tasks
@tnagorra
Update documentation and rename script names
2f58e53 
- Update docker syntax version
- Copy only files needed for yarn install
@tnagorra tnagorra merged commit 8894f3c into develop Nov 7, 2024
12 checks passed
@thenav56 thenav56 deleted the project/alpha-nginx-serve branch November 7, 2024 09:03
@thenav56 thenav56 mentioned this pull request Nov 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnagorra tnagorra tnagorra approved these changes

@samshara samshara Awaiting requested review from samshara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenav56 @tnagorra