Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end to end tests for epidemic type field report #1251

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add end to end tests for epidemic type field report #1251

merged 2 commits into from
Jul 15, 2024

Conversation

babinkarmacharya79
Copy link

@babinkarmacharya79 babinkarmacharya79 commented Jul 11, 2024 •
edited
Loading

Addresses:

Changes

  • End to End test for Epidemic type Field Report
  • Assertions for Epidemic type Field Report
  • Value Assertions for Epidemic type Field Report

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5f31b7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@babinkarmacharya79 babinkarmacharya79 force-pushed the feature/epidemic-field-report-e2e-tests branch from 21a0ae5 to 8e517ca Compare July 12, 2024 11:17
@babinkarmacharya79 babinkarmacharya79 marked this pull request as ready for review July 12, 2024 11:19
@babinkarmacharya79 babinkarmacharya79 force-pushed the feature/epidemic-field-report-e2e-tests branch from 8e517ca to 5f31b7e Compare July 12, 2024 11:29
samshara
samshara reviewed Jul 15, 2024
View reviewed changes
packages/e2e-tests/tests/epidemic-field-report/epidemic-field-report.spec.ts
Comment on lines +84 to +86
await expect(page.locator('input[name="dtype"]')).toHaveValue(
disasterType,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this assertions in next section

@samshara samshara merged commit 9e8840b into project/playwright Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

Assignees

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babinkarmacharya79 @samshara