Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BarChart Stories #1139

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix BarChart Stories #1139

merged 2 commits into from
Jun 7, 2024

Conversation

roshni73
Copy link
Collaborator

@roshni73 roshni73 commented Jun 5, 2024 •
edited
Loading

Addresses:

Changes

  • Fix:use template to write Barchart story
  • Fix Change in any one value of the bar affects the width of overall barchart

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@roshni73 roshni73 added this to the Storybook milestone Jun 5, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54f8dfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roshni73 roshni73 changed the title Fix:use template to write Barchart story,Fix Change in any one value … Fix BarChart Stories Jun 5, 2024
@samshara samshara force-pushed the fix/barchart-stories branch from 06b4002 to 0b40d90 Compare June 7, 2024 04:55
@samshara samshara force-pushed the fix/barchart-stories branch from d55ebac to 54f8dfa Compare June 7, 2024 05:29
@samshara samshara merged commit a257c17 into project/storybook Jun 7, 2024
9 checks passed
@samshara samshara deleted the fix/barchart-stories branch June 7, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Storybook
Development

Successfully merging this pull request may close these issues.
2 participants
@roshni73 @samshara