fix: handle null values for country key indicators

IFRCGo · Jan 24, 2024 · 36209e3 · 36209e3
1 parent 988739b
commit 36209e3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/src/App/routes/CountryRoutes.tsx b/src/App/routes/CountryRoutes.tsx
@@ -4,7 +4,7 @@ import {
     useParams,
 } from 'react-router-dom';
 import { isDefined, isTruthyString } from '@togglecorp/fujs';
-mport { countryIdToRegionIdMap } from '#utils/domain/country';
+import { countryIdToRegionIdMap } from '#utils/domain/country';
 
 import Auth from '../Auth';
 import {

diff --git a/src/views/Country/index.tsx b/src/views/Country/index.tsx
@@ -62,15 +62,6 @@ export function Component() {
 
     const { isAuthenticated } = useAuth();
 
-    const {
-        pending: aggregatedAppealPending,
-        response: aggregatedAppealResponse,
-    } = useRequest({
-        skip: isNotDefined(countryId) || isRegion,
-        url: '/api/v2/appeal/aggregated',
-        query: { country: Number(countryId) },
-    });
-
     const outletContext = useMemo<CountryOutletContext>(
         () => ({
             countryId,

diff --git a/src/views/CountryProfileOverview/index.tsx b/src/views/CountryProfileOverview/index.tsx
@@ -45,7 +45,7 @@ export function Component() {
             />
             <TextOutput
                 label={strings.countryIndicatorsUrbanPopulationLabel}
-                value={`${indicatorResponse?.urban_population} %`}
+                value={isDefined(indicatorResponse?.urban_population) ? `${indicatorResponse?.urban_population} %` : undefined}
                 valueType="text"
                 strongValue
             />
@@ -63,7 +63,7 @@ export function Component() {
             />
             <TextOutput
                 label={strings.countryIndicatorsPovertyLabel}
-                value={`${indicatorResponse?.poverty} %`}
+                value={isDefined(indicatorResponse?.poverty) ? `${indicatorResponse?.poverty} %` : undefined}
                 valueType="text"
                 strongValue
             />
@@ -75,7 +75,7 @@ export function Component() {
             />
             <TextOutput
                 label={strings.countryIndicatorsLiteracyLabel}
-                value={`${indicatorResponse?.literacy} %`}
+                value={isDefined(indicatorResponse?.literacy) ? `${indicatorResponse?.literacy} %` : undefined}
                 valueType="text"
                 strongValue
             />