Skip to content

Commit

Permalink
Removed the Fixme in alert component, reverted the changes
Browse files Browse the repository at this point in the history
  • Loading branch information
roshni73 committed Jan 16, 2024
1 parent b37ee3e commit 2a7095a
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/Alert/i18n.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"namespace": "common",
"strings": {
"CopyErrorDetails": "Copy error details",
"alertCopyErrorDetails": "Copy error details",
"closeButtonTitle": "Close"
}
}
1 change: 0 additions & 1 deletion src/components/Alert/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ function Alert<N extends string>(props: Props<N>) {
onClick={handleCopyDebugMessageButtonClick}
variant="tertiary-on-dark"
>
{/* FIXME: there is string in json file */}
{strings.alertCopyErrorDetails}
</Button>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ interface GdacsEventDetails {
iso3: string;
countryname: string;
}[];
alert_sent?: boolean;
alert_level?: 'Red' | 'Orange' | 'Green' | 'Cones' | null;
alertlevel?: string;
alertscore?: number;
Expand Down
1 change: 0 additions & 1 deletion src/components/domain/RiskImminentEvents/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ type BaseProps = {
title: React.ReactNode;
bbox: LngLatBoundsLike | undefined;
defaultSource?: ImminentEventSource;
alertType?:string;
}

type Props = BaseProps & ({
Expand Down
2 changes: 2 additions & 0 deletions src/views/RegionRiskWatchImminent/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import getBbox from '@turf/bbox';

import RiskImminentEvents from '#components/domain/RiskImminentEvents';
import { RegionOutletContext } from '#utils/outletContext';

import styles from './styles.module.css';

// TODO: Add historic data chart
Expand All @@ -16,6 +17,7 @@ export function Component() {
() => (regionResponse ? getBbox(regionResponse.bbox) : undefined),
[regionResponse],
);

Check failure on line 20 in src/views/RegionRiskWatchImminent/index.tsx

View workflow job for this annotation

GitHub Actions / Lint JS

Trailing spaces not allowed
return (
<div className={styles.regionImminentRiskWatch}>
{regionResponse && (
Expand Down

0 comments on commit 2a7095a

Please sign in to comment.