Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Country page cronjobs scheduled to every week #2174

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Country page cronjobs scheduled to every week #2174

merged 5 commits into from
Jul 5, 2024

Conversation

susilnem
Copy link
Member

Addresses

Changes

  • Need to run the command to initiate the cronjobs in sentry
    ./manage.py cron_job_monitor

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@susilnem susilnem requested review from thenav56 and k9845 June 13, 2024 11:05
@szabozoltan69
Copy link
Contributor

szabozoltan69 commented Jun 13, 2024 •
edited
Loading

I can't find ingest_disaster_law timing... or was it a once-to-run only job?
Also ns_capaciity could be renamed to ns_capacity
(on api/management/commands/ingest_ns_capacity.py:47).

@thenav56 thenav56 marked this pull request as draft June 13, 2024 12:44
@susilnem susilnem force-pushed the feature/countrypage-cronjon branch from 1c7bac1 to f752b5d Compare June 18, 2024 06:41
@susilnem susilnem force-pushed the feature/countrypage-cronjon branch 3 times, most recently from 09683e9 to e376bd1 Compare July 3, 2024 04:05
@susilnem susilnem removed the request for review from k9845 July 3, 2024 05:05
thenav56
thenav56 requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes, let's use the comment to track them

api/management/commands/ingest_ns_directory.py Outdated Show resolved Hide resolved
api/management/commands/ingest_ns_document.py Outdated Show resolved Hide resolved
api/management/commands/ingest_ns_initiatives.py Outdated Show resolved Hide resolved
api/management/commands/ingest_ns_initiatives.py Outdated Show resolved Hide resolved
databank/management/commands/FDRS_INCOME.py Show resolved Hide resolved
databank/management/commands/ingest_hdr.py Show resolved Hide resolved
main/sentry.py Show resolved Hide resolved
main/sentry.py Show resolved Hide resolved
main/sentry.py Outdated Show resolved Hide resolved
main/sentry.py Show resolved Hide resolved
@susilnem susilnem force-pushed the feature/countrypage-cronjon branch from 59ec1cd to e7b5fdc Compare July 3, 2024 14:48
@susilnem susilnem force-pushed the feature/countrypage-cronjon branch from e7b5fdc to f93510a Compare July 4, 2024 04:35
@susilnem susilnem requested a review from thenav56 July 4, 2024 04:35
@susilnem susilnem force-pushed the feature/countrypage-cronjon branch 2 times, most recently from c59ad51 to fd02db0 Compare July 4, 2024 11:05
thenav56
thenav56 requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost wrap up.
Few minor suggestions

api/management/commands/ingest_ns_document.py Outdated Show resolved Hide resolved
databank/management/commands/ingest_climate.py Outdated Show resolved Hide resolved
api/management/commands/ingest_ns_initiatives.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the feature/countrypage-cronjon branch 2 times, most recently from b9163aa to af900bc Compare July 5, 2024 08:37
@susilnem susilnem requested a review from thenav56 July 5, 2024 08:38
@udaynwa udaynwa marked this pull request as ready for review July 5, 2024 08:54
@szabozoltan69 szabozoltan69 merged commit cd0ec4f into develop Jul 5, 2024
2 checks passed
@szabozoltan69 szabozoltan69 deleted the feature/countrypage-cronjon branch July 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenav56 thenav56 thenav56 approved these changes

@szabozoltan69 szabozoltan69 szabozoltan69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susilnem @szabozoltan69 @thenav56