-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global filter #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnagorra
requested changes
Apr 16, 2024
barshathakuri
force-pushed
the
feature/alert-filtered
branch
from
April 17, 2024 07:53
e6eb56c
to
28e18b8
Compare
samshara
approved these changes
Apr 17, 2024
puranban
suggested changes
Apr 17, 2024
puranban
reviewed
Apr 17, 2024
puranban
previously requested changes
Apr 22, 2024
src/views/Home/Filters/index.tsx
Outdated
Comment on lines
51
to
52
admin1?: NonNullable<NonNullable<NonNullable<AdminListQuery['public']>['admin1s']>['items']>; | ||
countries?: NonNullable<CountryListQuery['public']['allCountries']>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the type defined above for countries
, admin1
frozenhelium
force-pushed
the
feature/alert-filtered
branch
from
April 22, 2024 12:09
031d150
to
981d810
Compare
frozenhelium
force-pushed
the
feature/alert-filtered
branch
from
April 22, 2024 12:37
981d810
to
d60be9d
Compare
frozenhelium
force-pushed
the
feature/alert-filtered
branch
from
April 22, 2024 12:48
d60be9d
to
684b370
Compare
frozenhelium
approved these changes
Apr 22, 2024
frozenhelium
force-pushed
the
feature/alert-filtered
branch
from
April 22, 2024 13:09
684b370
to
868fa95
Compare
tnagorra
approved these changes
Apr 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.log
meant for debugging