Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global filter #31

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Add global filter #31

merged 4 commits into from
Apr 22, 2024

Conversation

barshathakuri
Copy link
Collaborator

@barshathakuri barshathakuri commented Apr 15, 2024

Addresses:

Changes

  • Add global filter for table and map

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

src/views/Home/index.tsx Outdated Show resolved Hide resolved
src/views/Home/Filters/index.tsx Outdated Show resolved Hide resolved
src/views/Home/Filters/index.tsx Outdated Show resolved Hide resolved
src/views/Home/Filters/index.tsx Outdated Show resolved Hide resolved
Comment on lines 51 to 52
admin1?: NonNullable<NonNullable<NonNullable<AdminListQuery['public']>['admin1s']>['items']>;
countries?: NonNullable<CountryListQuery['public']['allCountries']>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the type defined above for countries, admin1

src/views/Home/Filters/index.tsx Outdated Show resolved Hide resolved
@tnagorra tnagorra merged commit 5a51352 into develop Apr 22, 2024
4 checks passed
@frozenhelium frozenhelium deleted the feature/alert-filtered branch April 22, 2024 13:17
@barshathakuri barshathakuri mentioned this pull request Apr 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants