Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ingressClassName configurable in helm chart #185

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

Lusengeri
Copy link
Collaborator

This change allows ingress deployment in a cluster where the 'nginx' ingress class is unavailable.

Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @barshathakuri Could you merge this PR.

@thenav56 thenav56 force-pushed the feature/configurable-ingressclassname branch from 1c8c103 to 7c9699d Compare December 5, 2024 14:02
@thenav56 thenav56 force-pushed the feature/configurable-ingressclassname branch from 7c9699d to 00c904c Compare December 5, 2024 14:04
@thenav56 thenav56 force-pushed the feature/configurable-ingressclassname branch from 00c904c to 70155d3 Compare December 5, 2024 14:05
@thenav56 thenav56 merged commit 9427a6f into develop Dec 5, 2024
4 checks passed
@thenav56 thenav56 deleted the feature/configurable-ingressclassname branch December 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants