Skip to content

Commit

Permalink
Fix subscription styling
Browse files Browse the repository at this point in the history
  • Loading branch information
barshathakuri committed Dec 6, 2024
1 parent 8f03ef6 commit 6aad3dd
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 27 deletions.
16 changes: 7 additions & 9 deletions src/views/MySubscriptions/SubscriptionDetail/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ export function Component() {
<Container
contentViewType="vertical"
spacing="comfortable"
emptyMessage
filters={(
<>
<DateInput
Expand Down Expand Up @@ -279,14 +278,13 @@ export function Component() {
<Container
empty={alertsData?.alerts.items.length === 0}
emptyMessage={strings.susbcriptionEmptyMessage}
>
<RawList
data={alertsData?.alerts.items}
renderer={AlertInfoItem}
rendererParams={rendererParams}
keySelector={stringIdSelector}
/>
</Container>
/>
<RawList
data={alertsData?.alerts.items}
renderer={AlertInfoItem}
rendererParams={rendererParams}
keySelector={stringIdSelector}
/>
</Container>
</Page>
);
Expand Down
30 changes: 14 additions & 16 deletions src/views/MySubscriptions/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -454,14 +454,13 @@ export function Component() {
<Container
empty={data?.items.length === 0}
emptyMessage={strings.subscriptionEmptyMessage}
>
<RawList
data={data?.items}
renderer={SubscriptionTableItem}
rendererParams={activeRendererParams}
keySelector={subscriptionKeySelector}
/>
</Container>
/>
<RawList
data={data?.items}
renderer={SubscriptionTableItem}
rendererParams={activeRendererParams}
keySelector={subscriptionKeySelector}
/>
</TabPanel>
<TabPanel
name="archive"
Expand All @@ -470,14 +469,13 @@ export function Component() {
<Container
empty={data?.items.length === 0}
emptyMessage={strings.subscriptionEmptyMessage}
>
<RawList
data={data?.items}
renderer={SubscriptionTableItem}
rendererParams={archiveRendererParams}
keySelector={subscriptionKeySelector}
/>
</Container>
/>
<RawList
data={data?.items}
renderer={SubscriptionTableItem}
rendererParams={archiveRendererParams}
keySelector={subscriptionKeySelector}
/>
</TabPanel>
</Tabs>
</Container>
Expand Down
3 changes: 1 addition & 2 deletions src/views/NewSubscriptionModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ const formSchema: FormSchema = {
},
notifyByEmail: {
required: true,
requiredValidation: requiredCondition,
},
emailFrequency: {
required: !!value?.notifyByEmail,
Expand Down Expand Up @@ -278,7 +277,7 @@ function NewSubscriptionModal(props: Props) {
filterAlertCountry: subscription?.filterAlertCountry,
filterAlertAdmin1s: subscription?.filterAlertAdmin1s
?? [],
notifyByEmail: subscription?.notifyByEmail,
notifyByEmail: subscription?.notifyByEmail ?? false,
emailFrequency: subscription?.emailFrequency ?? undefined,
}), [subscription]);

Expand Down

0 comments on commit 6aad3dd

Please sign in to comment.