Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed macosx tutorial to properly handle different mac arch possibi… #1544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azaidi06
Copy link
Contributor

…lities with single command

Fixes

This fixes issue #1497 : #1497

Summary/Motivation:

New Mac devices now come with apple silicon which requires a different set of binaries relative to previous intel version -- in order to accommodate both types, a single command is used to determine and download what's appropriate.

Changes proposed in this PR:

Simply changing the tutorial for Macs to accommodate the potential differences in CPU arch -- the command will be able to determine which arch is being used on the device and download the appropriate binaries. This will help mitigate potential mistakes of downloading the incorrect type/version for apple silicon vs intel.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (5841433) to head (2b7dffe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.01%     
==========================================
  Files         384      384              
  Lines       62338    62338              
  Branches    10222    10222              
==========================================
- Hits        48034    48031       -3     
- Misses      11875    11879       +4     
+ Partials     2429     2428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants