-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use el8
binaries when we encounter RHEL9
#1457
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1457 +/- ##
==========================================
- Coverage 76.36% 76.35% -0.01%
==========================================
Files 394 394
Lines 64953 64953
Branches 14404 14404
==========================================
- Hits 49601 49598 -3
- Misses 12793 12797 +4
+ Partials 2559 2558 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@eslickj just pinging you in case you can think of any reason why this change could have unexpected consequences; to me, without knowing the details, it looks reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for @mrmundt to run testing from this branch
This PR is going to be superseded by IDAES/idaes-ext#274 <- completion of that will mean we have a RHEL9 binary anyway, so this temporary remapping will be irrelevant. |
Closed in preference to IDAES/idaes-ext#274 |
Fixes #1456
Hopefully. I don't have RHEL9 or Rocky9, so I haven't tested.
Changes proposed in this PR:
el9
,rhel9
, androcky9
to point to ourel8
binariesLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: