Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Keycloak 24/re-encrypt Route #2261

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

pgodowski
Copy link
Contributor

What this PR does / why we need it:

In Keycloak 24, when it is behind re-encrypt Route, any incoming http requests fail with http/500, with NPE exception saying http Host header is missing. Seems the fix is to add the proxy headers setting to parse x-forwarded http header.

Which issue(s) this PR fixes:
Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65100 and keycloak/keycloak#33988

Special notes for your reviewer:

  1. How the test is done?

Do fresh deploy of Keycloak 24 on ROSA cluster. Check Route keycloak created works fine and renders Keycloak Admin UI

@ibm-ci-bot
Copy link
Collaborator

Hi @pgodowski. Thanks for your PR.

I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, pgodowski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit fb0d36c into IBM:master Oct 17, 2024
5 of 10 checks passed
Daniel-Fan pushed a commit to Daniel-Fan/ibm-common-service-operator that referenced this pull request Oct 17, 2024
ibm-ci-bot pushed a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Piotr Godowski <[email protected]>
Co-authored-by: Piotr Godowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants