remove velero addon and cold backup annotations #2259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Revert the changes to add the velero addon annotation and its required accompanying annotation
k8s.enterprisedb.io/snapshotAllowColdBackupOnPrimary: enabled
since we have never adopted its use in BR and it is causing problems with CPD BR process.Originally, this was implemented because this addon method is what is officially supported by EDB and the CPD team is able to overwrite it with their own addon (external-backup-adapter). However, the
k8s.enterprisedb.io/snapshotAllowColdBackupOnPrimary: enabled
annotation is not overwritten and there is an edge case defined in the linked issue where this label is problematic. Since we do not use these sets of annotations, I believe it best to go ahead and remove them for the 4.10 release.Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/PrivateCloud-analytics/CPD-Quality/issues/31335
Special notes for your reviewer:
How to backport this PR to other branch:
backport <branch-name>
backport <branch-name>
and leave a comment/backport
to trigger the backport action