Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove velero addon and cold backup annotations #2259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluzarraga
Copy link
Member

What this PR does / why we need it:
Revert the changes to add the velero addon annotation and its required accompanying annotation k8s.enterprisedb.io/snapshotAllowColdBackupOnPrimary: enabled since we have never adopted its use in BR and it is causing problems with CPD BR process.

Originally, this was implemented because this addon method is what is officially supported by EDB and the CPD team is able to overwrite it with their own addon (external-backup-adapter). However, the k8s.enterprisedb.io/snapshotAllowColdBackupOnPrimary: enabled annotation is not overwritten and there is an edge case defined in the linked issue where this label is problematic. Since we do not use these sets of annotations, I believe it best to go ahead and remove them for the 4.10 release.

Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/PrivateCloud-analytics/CPD-Quality/issues/31335

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bluzarraga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants