Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2 replicas for Keycloak EDB on starterset #2256

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Jamstah
Copy link
Member

@Jamstah Jamstah commented Oct 16, 2024

What this PR does / why we need it:

Using one replica prevents cluster upgrade due to the pod disruption budget, so set the default to use two.

Which issue(s) this PR fixes:
Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65103

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

Using one replica prevents cluster upgrade due to the pod disruption budget, so set the default to use two.

Signed-off-by: James Hewitt <[email protected]>
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, Jamstah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 12dffd1 into IBM:master Oct 16, 2024
6 of 9 checks passed
Daniel-Fan pushed a commit to Daniel-Fan/ibm-common-service-operator that referenced this pull request Oct 16, 2024
Using one replica prevents cluster upgrade due to the pod disruption budget, so set the default to use two.

Signed-off-by: James Hewitt <[email protected]>
ibm-ci-bot pushed a commit that referenced this pull request Oct 16, 2024
Using one replica prevents cluster upgrade due to the pod disruption budget, so set the default to use two.

Signed-off-by: James Hewitt <[email protected]>
Co-authored-by: James Hewitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants