conditionally wait for ibm-licensing-instance #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Li <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qpdpQ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
YCShen1010
reviewed
Oct 15, 2024
Signed-off-by: Allen Li <[email protected]>
YCShen1010
reviewed
Oct 16, 2024
| info "No ibm-licensing-operator found, skipping" | ||
| return 0 | ||
| fi | ||
|
|
||
| local ns=$("$OC" get deployments -A | grep ibm-licensing-service-instance | cut -d ' ' -f1) |
There was a problem hiding this comment.
Sorry, one more comment, I noticed this line is also included in wait_for_licensing_instance_deployment, is it possible move this check under the above if condition? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We should only wait for ibm-licensing-instance when ibm-licensing operator is found, it could help to reducing the waiting time.