Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added configuration for instana metrics collection #2249

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

bitscuit
Copy link
Member

@bitscuit bitscuit commented Oct 9, 2024

How to test

  1. Install cs-operator
  2. Update image on cluster with changes from this PR
  3. Update CRD on cluster with changes from this PR
  4. Update CommonService CR with enableInstanaMetricCollection: true
  5. Verify that setting propagates to OperandConfig for IM and UI

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qpdpQ
Copy link
Contributor

qpdpQ commented Oct 10, 2024

/lgtm

@ibm-ci-bot ibm-ci-bot merged commit 3083441 into IBM:master Oct 10, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants