Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing displayName #1897

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Removing displayName #1897

wants to merge 1 commit into from

Conversation

giacomoch
Copy link
Member

@giacomoch giacomoch commented Apr 2, 2024

https://github.ibm.com/IBMPrivateCloud/roadmap/issues/62819

Removing the displayName means the banner can be rendered instead of the HTML:

Before:
image

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: giacomoch
Once this PR has been reviewed and has the lgtm label, please assign bluzarraga for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants