Fix warnings related to dangling comments and lossy conversions #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently numerous warnings have displayed related to lossy conversions and dangling `javadoc` comments. This update ensures that there are no dangling `javadoc` comments these changes fall into various categories such as unused code that has `javadoc` comments embedded, empty `javadoc` comments, duplicate `javadoc` comments, or javadoc comments that are not located above a declaration. Updates were also made to `XDHPublicKeyImpl`, `BaseTestChaCha20KAT`, and `BaseTestChaCha20NoReuse` to explicitly cast an int to a byte OR make use of a common utility function `BaseUtils.hexStringToByteArray` that does not have such a lossy conversion present. While fixing dangling comments one test `testRSASignatureSHA512_256` was found to be commented out. It appears to execute correctly and does seem like a valid test so this test was uncommented. Two spaces found in the pom.xml were removed for consistency. Signed-off-by: Jason Katonica <[email protected]>
jasonkatonica
requested review from
taoliult,
KostasTsiounis,
johnpeck-us-ibm and
JinhangZhang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently numerous warnings have displayed related to lossy conversions and dangling
javadoccomments.This update ensures that there are no dangling
javadoccomments these changes fall into various categories such as unused code that hasjavadoccomments embedded, emptyjavadoccomments, duplicatejavadoccomments, or javadoc comments that are not located above a declaration.Updates were also made to
XDHPublicKeyImpl,BaseTestChaCha20KAT, andBaseTestChaCha20NoReuseto explicitly cast an int to a byte OR make use of a common utility functionBaseUtils.hexStringToByteArraythat does not have such a lossy conversion present.While fixing dangling comments one test
testRSASignatureSHA512_256was found to be commented out. It appears to execute correctly and does seem like a valid test so this test was uncommented.Two spaces found in the pom.xml were removed for consistency.
Signed-off-by: Jason Katonica [email protected]