Use correct output size for AES on z platform #263
+196
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkatonica
requested review from
taoliult,
KostasTsiounis,
johnpeck-us-ibm and
JinhangZhang
johnpeck-us-ibm
approved these changes
Oct 16, 2024
KostasTsiounis
requested changes
Oct 17, 2024
jasonkatonica
force-pushed
the
katonica/issue240/fixbufferreset
branch
from
4fe3f0a
to
64d8350
Compare
When the fast z command is available the AES cipher does not return the correct output size on platform z. Platform z uses a different buffer and output size calculation. The method `engineGetOutputSize` when running on platform z should return and take this into account. A new test was added to exercise byte buffers and various combinations of encryption, decryption, and orders of doFinal and update operations which can be used to recreate the problem. Closes IBM#240 Signed-off-by: Jason Katonica <[email protected]>
jasonkatonica
force-pushed
the
katonica/issue240/fixbufferreset
branch
from
64d8350
to
25d34b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the fast z command is available the AES cipher does not return the correct output size on platform z.
Platform z uses a different buffer and output size calculation. The method
engineGetOutputSizewhen running on platform z should return and take this into account.A new test was added to exercise byte buffers and various combinations of encryption, decryption, and orders of doFinal and update operations which can be used to recreate the problem.
Closes #240
Signed-off-by: Jason Katonica [email protected]