Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have been updated to use Junit5. Changes made include:
junit-vintage-engine
dependency. This is no longer in use given all tests now make use of Junit 5.junit.framework.TestCase
.@Test
annotation.main()
methods of tests were removed as they are no longer in use. Tests can be run using various Junit 5 test execution tools such as IDEs, command line tools, andmvn
surefire which is already in place in this project.BaseTest
was removed as it is no longer in use and represents a Junit 3 test. A newBaseTestJunit5
test has been created to represent the new base for the test hierarchy.Utils
class was in use. This was corrected to use the correct class.TestAESGCM_192
,TestAESGCM_256
, andTestRSA_4096
were added to theOpenJCEPlus
andOpenJCEPlusFIPS
provider test suites.TestECDHInteropBC
,TestRSATypeCheckEnabled
,TestAES_192
, andTestAES_256
were added to theOpenJCEPlus
provider test suiteTestAES_192
andTestAES_256
were removed from theTestMultithreadFIPS
since these tests take a long period of time to complete. Coverage functionally is still maintained since they are executed as part of theOpenJCEPlusFIPS
provider tests.TestMultithreadFIPS
andTestMultithread
.