Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved serviceID cleanup #89

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Improved serviceID cleanup #89

merged 5 commits into from
Apr 25, 2024

Conversation

reggeenr
Copy link
Collaborator

Cleanup scripts regularly fail, if more than one serviceID with that name exists

qu1queee
qu1queee requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! can u check if the following request for changes work for your function?

based on https://www.shellcheck.net/wiki/SC2086

cloudant-change-listener/run Outdated Show resolved Hide resolved
cos2cos/run Outdated Show resolved Hide resolved
function2job/run Outdated Show resolved Hide resolved
satellite-connector-to-vpc-vsi/run Outdated Show resolved Hide resolved
reggeenr and others added 4 commits April 25, 2024 14:55
@reggeenr @qu1queee
Update cloudant-change-listener/run
88b3d85 
Co-authored-by: Enrique Encalada <[email protected]>
@reggeenr @qu1queee
Update cos2cos/run
11d2efc 
Co-authored-by: Enrique Encalada <[email protected]>
@reggeenr @qu1queee
Update function2job/run
37478ed 
Co-authored-by: Enrique Encalada <[email protected]>
@reggeenr @qu1queee
Update satellite-connector-to-vpc-vsi/run
64f2ed1 
Co-authored-by: Enrique Encalada <[email protected]>
@reggeenr reggeenr changed the title Iimproved serviceID cleanup Improved serviceID cleanup Apr 25, 2024
@reggeenr
Copy link
Collaborator Author

Thanks for your suggestions. I committed all of them

@qu1queee qu1queee self-requested a review April 25, 2024 13:11
@qu1queee qu1queee merged commit ae92253 into main Apr 25, 2024
2 checks passed
@reggeenr reggeenr deleted the improve-serviceid-cleanups branch November 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reggeenr @qu1queee