Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cloudant change listener #66

Merged
merged 22 commits into from
Dec 6, 2023

Conversation

groezing
Copy link
Member

Adding a new sample as Daemon Job. Also add a reference to the overall Readme.
Overall readme needs to be enhanced with more info about the sample.

Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general note: Can you please adjust the folder naming and use dashes instead of underscores for the folder?

On the naming of files and folder, I suggest to shrink it to the following set of files:

cloudant-change-listener
|- .ceignore
|- .gitignore
|- build
|- Dockerfile
|- function
|   `- function.js
|
|- images
|   `- Architecture.png
|
|- job
|   |- api-helpers.mjs
|   |- job.mjs (formerly cloudant_change_listener.mjs)
|   `- package.json
|
|- README.md
`- run

README.md Outdated Show resolved Hide resolved
cloudant_change_listener/README.md Outdated Show resolved Hide resolved
@groezing
Copy link
Member Author

groezing commented Dec 4, 2023

Review comments considered

@groezing groezing requested a review from reggeenr December 4, 2023 14:35
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @groezing , thanks for addressing the comments and adjust the structure. I just did a peak review and a small number of places that needs an adjustment due to the re-arrangement of files and folders.

I will do one more round of testing and verify the whole scenario works end to end.

README.md Outdated Show resolved Hide resolved
cloudant-change-listener/Dockerfile Show resolved Hide resolved
echo "Creating the Code Engine daemon job 'cloudant-change-listener-job' ..."
ibmcloud ce job create \
--name cloudant-change-listener-job \
--src . \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option most likely needs to get changed.

--src ./job

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --src is ok, because it must point to the folder where the Dockerfile is located.

Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @groezing for putting so much effort in this sample that provides an end-to-end running solution to demonstrate how to listen on change events in a cloudant database!

LGTM

@reggeenr reggeenr merged commit 6a864eb into IBM:main Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants