Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug warning when cleanup thread is not finished #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dereyck
Copy link

@dereyck dereyck commented Nov 19, 2024

Introduced a debug warning in the scheduler to log when the cleanup thread
has not finished cleaning up all threads marked for destruction before it
is descheduled. This ensures that any unfinished cleanup work is flagged,
helping to identify potential issues with thread management or incomplete
cleanup processes in the system.

@dgruss
Copy link
Member

dgruss commented Nov 19, 2024

this patch would slow down things, potentially exacerbating the problem.
i would rather add a counter in the scheduler that is atomically increased/decreased and print a warning in the scheduler when the last thread was the cleanupthread and the counter is > 5 or so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants