added a SampleHumanServicesTest class #1311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
suggested changes
Nov 17, 2024
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Show resolved
Hide resolved
6 tasks
mherman22
suggested changes
Nov 20, 2024
There was a problem hiding this comment.
@josephbate this looks good,
just a few minor suggestions below:
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| Sample samp = new Sample(); | ||
| samp.setEnteredDate(enteredDate); | ||
| samp.setReceivedTimestamp(doc); |
There was a problem hiding this comment.
Suggested change
| samp.setReceivedTimestamp(doc); | |
| samp.setReceivedTimestamp(new Timestamp(new SimpleDateFormat("dd/MM/yyyy").parse(SAMPLE_RECEIVED_TIMESTAMP).getTime())); |
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openelisglobal/samplehuman/SampleHumanServiceTest.java
Outdated
Show resolved
Hide resolved
mherman22
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
added a SampleHumanServicesTest class
Screenshots
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Other
[Add any additional information or notes here]