Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the search bar responsive #1294

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Conversation

Bahati308
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@mozzy11
Copy link
Collaborator

mozzy11 commented Oct 30, 2024

Thanks @Bahati308 ,
can you add screenshots or a screen recording ??

@Bahati308
Copy link
Contributor Author

here is an attachment sir, @mozzy11
Screenshot from 2024-09-12 19-38-42

@Bahati308
Copy link
Contributor Author

I put the search bar slightly below the banner for clarity(to make the banner visible )

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bahati308 .
Can you make the blue search bar strecth up to the left border like here
image

@Bahati308
Copy link
Contributor Author

thanks @mozzy11, why not, lemme go ahead and do it.

@Bahati308
Copy link
Contributor Author

hello @mozzy11 , here are the required changes attended to as requested.

Screenshot from 2024-11-01 16-28-23

Screenshot from 2024-11-01 16-29-00

Screenshot from 2024-11-01 16-29-32

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bahati308 ,
Can you adde a few Patients in your instace and attach the screen shot with a few patient Results ??

@Bahati308
Copy link
Contributor Author

Bahati308 commented Nov 6, 2024

okay, sir here are the findings.
Screenshot from 2024-11-06 20-24-50
Screenshot from 2024-11-06 20-25-38

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 6, 2024

i cant view the screen shots

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 6, 2024

Thanks @Bahati308

can you try to replicate some thing like this

image

image

image

The results page should always vertically allign with the search bar

@Bahati308
Copy link
Contributor Author

Okay, lemme go for it

@Bahati308
Copy link
Contributor Author

thanks for the advise sir, here are the screenshots to backup the modifications made
Screenshot from 2024-11-06 21-45-32
Screenshot from 2024-11-06 21-46-03
Screenshot from 2024-11-06 21-46-17

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 6, 2024

Thanks @Bahati308

@mozzy11 mozzy11 merged commit 59cd962 into I-TECH-UW:develop Nov 6, 2024
4 checks passed
@Bahati308
Copy link
Contributor Author

welcome @mozzy11 , thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants