Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Query the Client Registry to retrieve patient data and import it into OpenELIS #1219

Merged
merged 24 commits into from
Oct 2, 2024

Conversation

mherman22
Copy link
Contributor

@mherman22 mherman22 commented Aug 6, 2024

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@mherman22 mherman22 force-pushed the queryCR branch 2 times, most recently from b39e027 to bb27300 Compare August 7, 2024 07:49
Copy link

👋 Hi, @mherman22,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Aug 22, 2024
@mozzy11
Copy link
Collaborator

mozzy11 commented Aug 27, 2024

@mherman22 any more prpgress on this ??

@mherman22
Copy link
Contributor Author

@mherman22 any more prpgress on this ??

I am working on updating this PR before end of day tomorrow. I have changes that query the client registry and return the patient to openelis, i am just debugging something to do with opencr and i created this PR to fix it at intrahealth/client-registry#148

@mozzy11
Copy link
Collaborator

mozzy11 commented Aug 27, 2024

Thanks @mherman22

@mherman22
Copy link
Contributor Author

when a client registry search is enabled

Screenshot from 2024-08-31 23-05-49

when the CR search is not enabled and there is only a local search

Screenshot from 2024-08-31 21-23-30

cc: @mozzy11

@mherman22 mherman22 marked this pull request as ready for review August 31, 2024 20:08
@mherman22
Copy link
Contributor Author

Screenshot from 2024-08-31 23-09-08
I added a toggle button to set the crResult to true when we want to do a CR search and it is false by default so that a CR search is not made when not required!

@mherman22
Copy link
Contributor Author

Screencast.from.2024-08-31.23-14-14.webm

cc: @mozzy11

@mherman22 mherman22 requested a review from mozzy11 September 2, 2024 19:14
@github-actions github-actions bot removed the merge conflict Merge Conflicts label Sep 3, 2024
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mherman22 for the great work .
i added a few minor comments.

But in general , the current Bussines Logic assumes the patient already exists in the Local DB before before it is searched from the Cleint Registry. That should be the case.

When searching the CR , the Logic should assume the patient already exists.

We should search directly the CR with the params , and if the returned FHIR patient results as a similar national ID or Patient ID as any local patient ,then its is removed from the CR results , otherwise we should have a button to import the CR result in the UI

@mherman22 mherman22 requested a review from mozzy11 September 22, 2024 19:09
@mozzy11
Copy link
Collaborator

mozzy11 commented Sep 23, 2024

Thanks @mherman22 .Generally Looks good
Can you attch an updated video for this ??

@mherman22 mherman22 requested a review from mozzy11 September 29, 2024 08:00
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mherman22 .
Generally Looks good. just update the property name to make it more meaningful

@mozzy11
Copy link
Collaborator

mozzy11 commented Oct 1, 2024

Thanks @mherman22 . Looks good

@mozzy11 mozzy11 merged commit 2cf3d05 into I-TECH-UW:develop Oct 2, 2024
4 checks passed
@mherman22 mherman22 deleted the queryCR branch October 6, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants