Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EU action improvements for new cars #707

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

cdnninja
Copy link
Collaborator

@cdnninja cdnninja commented Jan 9, 2025

No description provided.

badnbusy and others added 2 commits January 9, 2025 12:07
support lock/unlock for hyundai ccs2
support charge start/stop for hyundai ccs2
@cdnninja
Copy link
Collaborator Author

cdnninja commented Jan 9, 2025

@badnbusy Created a PR from your branch. This will auto update as you make changes. Great work on this so far!

@cdnninja
Copy link
Collaborator Author

@badnbusy let me know when you think this is ready for review/ merge. If you open a PR just like this the checks will auto fix formatting issues.

@badnbusy
Copy link

Hi @cdnninja I think this should be good to go. I've tested it manually and it works so can't see any problems. Let me know if you need anything else.

p.s. what is the difference/need between these headers? Is it correct that all v2 calls (ccs2) require the latter or do both work?

self._get_authenticated_headers(
    token, vehicle.ccu_ccs2_protocol_support
)
self._get_control_headers(
    token, vehicle
)

Thanks

@cdnninja
Copy link
Collaborator Author

Not sure!

@cdnninja
Copy link
Collaborator Author

@badnbusy could you correct the formatting to pass pre commit?

@badnbusy
Copy link

@cdnninja I've made the formatting change that I think was causing it, but it doesn't really tell me the actual issue/line number. Can you check now? Thanks

@cdnninja
Copy link
Collaborator Author

Still failing. I'll merge though and then I can create a pr that it will auto fix.

@cdnninja cdnninja merged commit af1e0ae into Hyundai-Kia-Connect:master Jan 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants