fix: handle EU server time issue #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes EU reports old time stamps
for more information, see https://pre-commit.ci
|
@ZuinigeRijder you are thinking move this logic to the vehicle setting? |
|
Yes, I can make a proposal (new) Pull request? |
|
Of course! This is as much yours as mine! I don't have one of these cars anymore so can't say I spend much time on it. I just increased your access to admin on this repo as well. |
| @@ -49,7 +49,7 @@ def _get_authenticated_headers( | |||
| def _update_vehicle_properties_ccs2(self, vehicle: Vehicle, state: dict) -> None: | |||
| if get_child_value(state, "Date"): | |||
| # `Date` field is in UTC time | |||
| if vehicle.last_updated_at: | |||
| if not vehicle.last_updated_at: | |||
| vehicle.last_updated_at = parse_datetime( | |||
| get_child_value(state, "Date"), dt.timezone.utc | |||
There was a problem hiding this comment.
I think this was wrong, someone else already reported that this was wrong for ccs2, it should be self.data_timezone
ZuinigeRijder
requested changes
Oct 5, 2024
There was a problem hiding this comment.
I think you miss one use-case, I created a new Pull request with my proposal:
#643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes EU reports old time stamps