This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Update rewards #44
Open
Update rewards #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitomir2
commented
Apr 16, 2024
•
Vitomir2
commented
- make getRawDelegatorReward public function and move it on the correct place;
- create calculate total reward function that will get all other rewards of a delegated position;
- separate penalty calculation from the rewards;
- make a test case that tests if the same vesting position size, but with different periods shows different rewards and also if they are totally the same, opened at the same time and they've the same rewards.
- add missing comments for clarity;
create new _calculatePositionRewards method that will be used for the rewards calculation when getting the rewards; update _rewardParams to calculate elapsed time, not only the maturing end period; make a test case that tests if the same vesting position size, but with different period shows different rewards and also if they are totally the same, opened in the same time and they've the same rewards.
R-Santev
suggested changes
Apr 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.