sync with mlabbe:devel #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SIGCHLD is ignored (the default) then waitpid will always return error (-1) on linux. This caused the assertion to fail even when everything is working correctly. This change adds an empty SIGCHLD handler so waitpid will give a useful result. At the end the previous handler is restored.
…ndows when given non ASCII path due to incorrect length computed by NFDi_UTF8_Strlen(). Caused by NFDi_UTF8_Strlen() relying on right shifting negative value, which is implementation defined behavior. The issue was fixed by casting to a unsigned value before shifting.
Ported fix by Matt Borgerson (@mborgerson) from guillaumechereau/noc#11
Fix NFD_PickFolder() asserting in debug with non ASCII default path
Fix simple_exec's waitpid error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync