Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fill on stacked lines (II) #186

Closed
wants to merge 12 commits into from

Conversation

acs
Copy link
Contributor

@acs acs commented Jan 7, 2013

I have implemented a basic implementation for this feature. It does not support holes in the time series.

I have seen another try at:

#94

I will take a look to compare approaches.

@cesutherland
Copy link
Member

Could you create a fiddle for this from http://jsfiddle.net/cesutherland/Fk3tR/ ?

I had some issue trying to create one, but haven't debugged yet.

@acs
Copy link
Contributor Author

acs commented Jan 25, 2013

Sure Carl. I will work on that!

@acs
Copy link
Contributor Author

acs commented Mar 2, 2013

Carl, I am working on this issue. We need to take a decision: null values has sense in stacked charts? If so, null + x = null? Or we convert null values to zero?

I think that once I have this issue clear I can go ahead and finish this work.

@acs
Copy link
Contributor Author

acs commented Mar 2, 2013

Carl, playing a bit more I feel that the general prob is complex so I plan to solve it step by step. In Bitergia we have solved our main need. To have stacked, filled lines graphs with the restriction:

Data with positive values (non null), integer sequence number.

I think that in this scenario, it works pretty well. I am thinking in the best approach to improve Flotr2 for then general use. Maybe implement this scenario and check data series before drawing and it the data does not follow the restrictions, show a message and not display anything. But I continue thinking in it!

@cesutherland
Copy link
Member

@acs I was able to create a fiddle for this: http://jsfiddle.net/9BDG3/3/

Please take a look. There's some loop or something... the process runs away. Any ideas?

@acs
Copy link
Contributor Author

acs commented Jun 12, 2013

Carl, I have fixed the prob wit the loop. I can invest sometime this week to work on this.

Maybe the approach with NULL values could be that anything + NULL = NULL and try to display the stacked value as it is done with normal NULL values. Any thoughts?

@cesutherland
Copy link
Member

I think that approach makes sense!

What is the actual use-case? Why would there be null data at one time for a series, and not for another series?

Assuming the null value is 0 may actually be mis-leading.

@acs
Copy link
Contributor Author

acs commented Nov 25, 2019

Closing this PR ... outdated probably.

@acs acs closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants