-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increased the HDD to 3500 GB, from 500 GB originally, to speed-up the SplitBamByCellBarcode step #358
Open
kishorikonwar
wants to merge
12
commits into
master
Choose a base branch
from
kmk-split-bam-by-cellbarcode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new sctools to write the intermediate BAM files of SplitCellByBarcode in SAM format. The goal is to speed-up the step but at the expense of larger sized intermediate files in the step
nikellepetrillo
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good as long as it's okay to use 3500GB for disk!
jessicaway
reviewed
Aug 4, 2020
|
||
Int machine_mem_mb = 15258 | ||
Int cpu = 16 | ||
|
||
# we can calculate disk size for arrays of input files in WDL 1.0 | ||
Int disk = 500 | ||
Int disk = 3500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we calculate this based on input size rather than just always getting a ton of disk?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Speed-up the SplitCellByCellBarcode step of Optimus by modifying the sctools to write the intermediate BAM files of SplitCellByBarcode in SAM format. The goal is to speed-up the step but at the expense of larger sized intermediate files in the step
Changes
a) Changed the HDD from 500GB to 3500GB
b) Changed the docker image to a higher version of sctools