Explore usage tracking #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* look for hs config
anthmatic
commented
Jan 19, 2023
| if (firstFile) { | ||
| trackUsage(); | ||
| firstFile = false; | ||
| } |
There was a problem hiding this comment.
This code is executed for each file so this prevents trackUsage from being called multiple times
anthmatic
commented
Jan 19, 2023
| import { resolveConfigFile } from "prettier"; | ||
|
|
||
| export const trackUsage = () => { | ||
| const rootPath = resolveConfigFile.sync(); |
There was a problem hiding this comment.
This looks up the prettier config and we use that to try to find the HubSpot config.
It's not guaranteed to be in the a child directly alongside a hubspot.config.yml or even exist.
anthmatic
commented
Jan 19, 2023
|
|
||
| if (!validateConfig()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
TODO:
- More logic to check
isTrackingAllowed - Log message to user to let them know that tracking is enabled and how they can disable it (hubspot config)
- Actually implement tracking. My current thought is that we'd spawn a detached child process to make the actual request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.