Merge pull request #359 from HubSpot/feature/csFix

Code style fix
HubSpot · Apr 18, 2024 · d9e757a · d9e757a
2 parents c25c400 + 1033927
commit d9e757a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/php-cs-fixer.yml b/.github/workflows/php-cs-fixer.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.0'
+          php-version: '7.4'
 
       - run: "composer install --no-interaction --no-progress --no-suggest"
 

diff --git a/lib/Factory.php b/lib/Factory.php
@@ -11,28 +11,28 @@
  */
 class Factory
 {
-    public static function create(ClientInterface $client = null, Config $config = null): Discovery
+    public static function create(?ClientInterface $client = null, ?Config $config = null): Discovery
     {
         return new Discovery($client ?: new Client(), $config ?: new Config());
     }
 
-    public static function createWithApiKey(string $apiKey, ClientInterface $client = null): Discovery
+    public static function createWithApiKey(string $apiKey, ?ClientInterface $client = null): Discovery
     {
         $config = new Config();
         $config->setApiKey($apiKey);
 
         return static::create($client, $config);
     }
 
-    public static function createWithDeveloperApiKey(string $apiKey, ClientInterface $client = null): Discovery
+    public static function createWithDeveloperApiKey(string $apiKey, ?ClientInterface $client = null): Discovery
     {
         $config = new Config();
         $config->setDeveloperApiKey($apiKey);
 
         return static::create($client, $config);
     }
 
-    public static function createWithAccessToken(string $accessToken, ClientInterface $client = null): Discovery
+    public static function createWithAccessToken(string $accessToken, ?ClientInterface $client = null): Discovery
     {
         $config = new Config();
         $config->setAccessToken($accessToken);

diff --git a/lib/RetryMiddlewareFactory.php b/lib/RetryMiddlewareFactory.php
@@ -9,14 +9,14 @@
 class RetryMiddlewareFactory
 {
     public static function createInternalErrorsMiddleware(
-        callable $delayFunction = null,
+        ?callable $delayFunction = null,
         int $maxRetries = 5
     ) {
         return static::createMiddlewareByHttpCodeRange(500, 504, $delayFunction, $maxRetries);
     }
 
     public static function createRateLimitMiddleware(
-        callable $delayFunction = null,
+        ?callable $delayFunction = null,
         int $maxRetries = 5
     ) {
         return static::createMiddlewareByHttpCodes([429], $delayFunction, $maxRetries);
@@ -53,7 +53,7 @@ public static function getRetryFunctionByRange(
         return function (
             $retries,
             Request $request,
-            Response $response = null
+            ?Response $response = null
         ) use ($from, $to, $maxRetries) {
             if ($retries >= $maxRetries) {
                 return false;
@@ -74,7 +74,7 @@ public static function getRetryFunction(array $codes, int $maxRetries = 5)
         return function (
             $retries,
             Request $request,
-            Response $response = null
+            ?Response $response = null
         ) use ($codes, $maxRetries) {
             if ($retries >= $maxRetries) {
                 return false;

diff --git a/tests/Unit/Utils/SignatureTest.php b/tests/Unit/Utils/SignatureTest.php
@@ -87,9 +87,9 @@ public function unexpectedValueExceptionTimestampTest(): void
     public static function generateHubspotSignatureV3(
         string $secret,
         string $requestBody,
-        string $httpUri = null,
+        ?string $httpUri = null,
         string $httpMethod = 'POST',
-        int $timestamp = null
+        ?int $timestamp = null
     ): string {
         $sourceString = $httpMethod.$httpUri.$requestBody.$timestamp;