Updated Bucky.coffee #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not reading options provided in the script tag. because default value was overriding. in line 86
| @@ -83,7 +83,7 @@ exportDef = -> | |||
| else if tagOptions[key]?.toString().toLowerCase() is 'false' | |||
| tagOptions[key] = null | |||
|
|
|||
| options = extend {}, defaults, tagOptions | |||
| options = extend {}, tagOptions, defaults | |||
There was a problem hiding this comment.
Either I'm crazy or extend is incorrectly implemented, b/c the original implementation absolutely should result in tagOptions overriding defaults.
There was a problem hiding this comment.
Agreed with @zackbloom:
# Extend impl copied straight from Bucky (https://github.com/HubSpot/BuckyClient/blob/646ab9ebcbcaaab4e68c7fcbf66e109dd418b3b3/bucky.coffee#L18-L22https://github.com/HubSpot/BuckyClient/blob/646ab9ebcbcaaab4e68c7fcbf66e109dd418b3b3/bucky.coffee#L18-L22https://github.com/HubSpot/BuckyClient/blob/646ab9ebcbcaaab4e68c7fcbf66e109dd418b3b3/bucky.coffee#L18-L22)https://github.com/HubSpot/BuckyClient/blob/646ab9ebcbcaaab4e68c7fcbf66e109dd418b3b3/bucky.coffee#L18-L22)
extend = (a, objs...) ->
for obj in objs
for key, val of obj
a[key] = val
a
console.log extend {}, { a: 1 }, { a: 2, b: 'other' }
# => {a: 2, b: "other"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not reading options provided in the script tag. because default value was overriding. in line 86