Talos fix #47
Open
Talos fix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.2.RC3
…e we any of sh or awk. Just parse the file and search for the right line =<initiatorname>
…ng iscsi cmds. Those functions are there to not interfere with ExecShellCmds. Remove nsenter execFunction since talos has not the minimal cmd to execute the commands in env. Run all the cmds inside local container that must add the corresponding packages. Fix a problem with blkdid inside a package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimal support for running huawei csi on talos (talos OS.
This minimal OS has no shell and is mainly running GO controller to pilot the kernel.
We present here the minimal modification to make the huawei run on this env.
Those fixes are of different kind:
1- remove the nsenter sh -c command. Make the container privileged is enough. Use binaries in the container instead.
2- Use the go library instead of using shell commands to read hostname or Initiatorname
3- Different fixes preventing running the huawei csi
In this context the huawei csi node works with a sidecar container running the iscsid daemon.