[FIX/Feature] Usage of Ubinetic On Demand oracle for retrieve prices #87
+713
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to Ubinetic stores timestamp with milliseconds format, we should add casting to standard-like timestamp object type. Issue shown here: ecadlabs/taquito#3093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new oracle implementation, which points to Ubinetic On Demand oracle proxy for getting price.
It is urgent fix of oracle outage issue. Harbinger oracle is no more up-to-date with prices and looks like there will not any future updates on it.
The contract and tests were written using the latest LIGO version (JsLIGO). The only difference against the original SmartPy implementation is throwing errors, which now throw the same Error codes but as
stringtype instead ofnat/int, as I think will not cause huge problems for service.