Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#320 [Ui] rule guide 바텀시트 #321

Merged
merged 13 commits into from
Feb 10, 2024
Merged

#320 [Ui] rule guide 바텀시트 #321

merged 13 commits into from
Feb 10, 2024

Conversation

murjune
Copy link
Member

@murjune murjune commented Nov 6, 2023 •
edited
Loading

관련 이슈

작업한 내용

Screen_Recording_20231106_232354_Hous-.mp4
  • 룰가이드 바텀 시트 content 컴포넌트
  • 룰가이드 로티 파일 3 추가
  • 룰가이드 바텀 시트 navigate 로직 컴포넌트 RuleScreen에 추가

PR 포인트

  • 현재, 로티 파일 2개의 파일이 안 열려서 나중에 change할 예정
  • 나중에 page 확인용 Text 컴포넌트 하나가 추가로 있는데, 머지 하기 전에 삭제하겠습니다!

@murjune murjune requested a review from KWY0218 November 6, 2023 14:20
@murjune murjune self-assigned this Nov 6, 2023
@murjune murjune requested a review from 2zerozu November 6, 2023 14:24
@murjune murjune added 준원🐻 준원이가 작업함! ui ui 관련 작업 Pull Request🔥 풀리퀘 날림! release❤️ 릴리즈!!!!! labels Nov 6, 2023
KWY0218
KWY0218 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@KWY0218 KWY0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버전 업하구 작업 하시느라 고생하셨습니다..!
👍

@2zerozu 2zerozu removed the release❤️ 릴리즈!!!!! label Nov 23, 2023
2zerozu
2zerozu approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@2zerozu 2zerozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저의 어푸를 기다리셨군요.. 고생하셨습니다 희희

@murjune
Copy link
Member Author

murjune commented Nov 29, 2023

인영이랑 lottie file 좀 더 얘기를 해보고 반영하도록하겠습니다!

@murjune
Copy link
Member Author

murjune commented Feb 10, 2024

드디어 해결을 해버린~

@murjune murjune merged commit 1a750e4 into develop Feb 10, 2024
1 check passed
@murjune murjune deleted the feature/#320-rule-guide branch March 10, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2zerozu 2zerozu 2zerozu approved these changes

@KWY0218 KWY0218 KWY0218 approved these changes

Assignees

@murjune murjune

Labels
Pull Request🔥 풀리퀘 날림! ui ui 관련 작업 준원🐻 준원이가 작업함!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat/ui] rule 가이드 바텀 시트
3 participants
@murjune @KWY0218 @2zerozu