Agent should failed on SocketNotFoundException jitsi#280

If there are no matching candidate because a configuration mistake then the agent should failed.
Horcrux7 · Jun 3, 2024 · d9245d9 · d9245d9
1 parent a53b402
commit d9245d9
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/org/ice4j/ice/ConnectivityCheckClient.java b/src/main/java/org/ice4j/ice/ConnectivityCheckClient.java
@@ -344,15 +344,15 @@ protected TransactionID startCheckForPair(
             {
                 logger.trace("checking pair " + candidatePair + " tid " + tran);
             }
+
+            return tran;
         }
         catch (NetAccessManager.SocketNotFoundException e)
         {
             logger.info("Could not start connectivity check: " + e.getMessage());
         }
         catch (Exception ex)
         {
-            tran = null;
-
             IceSocketWrapper stunSocket = localCandidate.getStunSocket(null);
 
             if (stunSocket != null)
@@ -376,7 +376,7 @@ protected TransactionID startCheckForPair(
             }
         }
 
-        return tran;
+        return null;
     }
 
     /**
@@ -944,6 +944,7 @@ protected void run()
                             "Pair failed: "
                                 + pairToCheck.toShortString());
                         pairToCheck.setStateFailed();
+                        updateCheckListAndTimerStates(pairToCheck);
                     }
                     else
                     {