Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI Issue Label To Templates #453

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

TimothyWillard
Copy link
Contributor

Describe your changes.

This pull request adds a cli label to the issue templates. This is to help tag/group an increasing number of command line related issues. If this PR looks good then I'll actually create the label before merging.

@TimothyWillard TimothyWillard added low priority Low priority. quick issue Short or easy fix. meta/workflow Relating to CI / issue templates / testing frameworks / etc. labels Jan 8, 2025
@pearsonca
Copy link
Contributor

probably not to deal with in this issue, but: i would like these label options to get translated to actually tag the issues. i haven't been bothering to manually add them to the issues in addition to clicking them on the select box.

desired behavior: on submit, ingest that section (and maybe remove it?), and add the labels. no need to handle edits / etc - that can all be done manually later.

@TimothyWillard
Copy link
Contributor Author

probably not to deal with in this issue, but: i would like these label options to get translated to actually tag the issues. i haven't been bothering to manually add them to the issues in addition to clicking them on the select box.

desired behavior: on submit, ingest that section (and maybe remove it?), and add the labels. no need to handle edits / etc - that can all be done manually later.

See GH-319

@pearsonca
Copy link
Contributor

probably not to deal with in this issue, but: i would like these label options to get translated to actually tag the issues. i haven't been bothering to manually add them to the issues in addition to clicking them on the select box.
desired behavior: on submit, ingest that section (and maybe remove it?), and add the labels. no need to handle edits / etc - that can all be done manually later.

See GH-319

I remember there being some issue with the auto-labelling, but it's unclear from that what the problem is?

@emprzy
Copy link
Collaborator

emprzy commented Jan 9, 2025

probably not to deal with in this issue, but: i would like these label options to get translated to actually tag the issues. i haven't been bothering to manually add them to the issues in addition to clicking them on the select box.
desired behavior: on submit, ingest that section (and maybe remove it?), and add the labels. no need to handle edits / etc - that can all be done manually later.

See GH-319

I remember there being some issue with the auto-labelling, but it's unclear from that what the problem is?

@pearsonca Most of the auto-labelling schemas apply labels based on the presence of keywords in an issue/PR. That is, if the term cli appears anywhere in the issue description, the issue will automatically receive a cli label. This was creating a certain degree of confusion/messiness when certain keywords were used in issues and spurring the issue to receive that label, even if it the label was not an accurate description of the purpose of the ticket. This feature was removed with GH #327 .

The purpose of the label dropdown within issues is to prompt the user to actually think about the labels their issue should have, with the idea that they could easily choose them again on the actual GitHub sidebar that applies tags to issues. I understand this is more than sub-optimal (to make users select labels twice), but it may be better than occasional auto-tagging with useless tags. I don't know, I'm open to re-adding it. I defer to Tim.

@TimothyWillard TimothyWillard merged commit 8da6b26 into main Jan 10, 2025
@TimothyWillard TimothyWillard deleted the meta/add-CLI-issue-label branch January 10, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. quick issue Short or easy fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants