Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit types to pull_request trigger #426

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

TimothyWillard
Copy link
Contributor

@TimothyWillard TimothyWillard commented Dec 12, 2024

Describe your changes.

This pull request modifies the pull request related triggers slightly (see below). This is being merged into main instead of dev because we want to maintain a consistent set of actions across branches (workflow is determined by base branch) and will pull these edits from main back into dev after merging.

Does this pull request make any user interface changes? If so please describe.

The user interface changes are the CI GitHub actions will now trigger when a PR is edited (most importantly for GH-412 when the target branch is changed) and when a PR is changed from draft to ready for review. The previous pull request triggers for actions still hold as well.

What does your pull request address? Tag relevant issues.

This pull request addresses GH-412.

Includes the defaults as well as the 'edited' and `ready_for_review` types.
@TimothyWillard TimothyWillard added bug Defects or errors in the code. high priority High priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. quick issue Short or easy fix. labels Dec 12, 2024
@TimothyWillard TimothyWillard linked an issue Dec 12, 2024 that may be closed by this pull request
@TimothyWillard TimothyWillard merged commit af3ad81 into main Dec 12, 2024
@TimothyWillard TimothyWillard deleted the feature/412/run-actions-on-pr-change branch December 12, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or errors in the code. high priority High priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. quick issue Short or easy fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Run CI GitHub Action On Changes To Pull Request
3 participants