-
Notifications
You must be signed in to change notification settings - Fork 47
Slurm postprocess #502
base: main
Are you sure you want to change the base?
Slurm postprocess #502
Conversation
I'm approving this, but i have one question: are we going to have issues where we need to constantly change the slack channel id? I see a lot of commits changing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks !
some thought
- need to make the channel-id an argument at submission. I'll work on that.
- is there some changes in the postprocessing/*_SLURM.R that could be backproppagated into the template files ? Do we still need the template files if these are the default one ?
Need to think on how to merge that as we're moving repository |
most of the slack channel commits were because it wasn't working. but making it an argument makes sense. Could possibly backpropagate so it runs automatically on AWS as well? but not sure exactly on the compatibility? Also is set to be specifically for just processing one run, whereas the template allows for multiple buckets for SMH so there's some finicky things that need manual inputs there... |
|
Added files for automatic postprocessing on MARCC. Postprocessing.sh script will run these automatically after a run and flepibot will send the results.